Messages in this thread | | | Date | Wed, 26 Sep 2012 14:21:33 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask |
| |
On 09/26/2012 01:40 PM, Liu, Chuansheng wrote: >> Btw, on a slightly different note, I'm also rather surprised that the above >> code doesn't care about the return value of chip->irq_set_affinity() .. >> Shouldn't we warn if that fails? > > It seems another case when irq_set_affinity is NULL whenever affinity is changed or not before that, > For this case, I suppose the chip is not supporting set_affinity, then the chip should set all > related irqs into just CPU0, otherwise, it will bring some trouble, do you agree? >
Hmm.. no, I wouldn't jump to do that. Moreover, note that there are patches in -tip to enable CPU 0 hotplug. So doing the above might not be terribly helpful going forward.
> I guess this case should be covered outside fixup_irqs() code. >
Regards, Srivatsa S. Bhat
| |