Messages in this thread | | | Date | Wed, 26 Sep 2012 13:57:38 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask |
| |
On 09/26/2012 01:47 PM, Liu, Chuansheng wrote: >> Shouldn't we warn if that fails? > printk("Cannot set affinity for irq %i\n", irq); > This is the warning when set affinity failed. >
I know.. What I meant is, the code warns only if chip->irq_set_affinity is NULL and doesn't care if chip->irq_set_affinity was not NULL and the function failed to set the affinity (ie., when chip->irq_set_affinity() returns error). In other words, I meant to say that this is one more case where we need to warn about our failure to set the irq affinity.
Regards, Srivatsa S. Bhat
| |