lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask
Date
> > +		} else if (cpumask_test_cpu(cpu, data->affinity))
> > + cpumask_clear_cpu(cpu, data->affinity);
> >
>
> You meant to use 'affinity' (instead of data->affinity) in the above 2 statements
> right? Note that we do chip->irq_set_affinity(data, affinity, true); further down.
>

Yes, I have noticed it, used data->affinity here is just for avoiding compile warning.
in fact affinity == data->affinity, but affinity pointer is const type,
And cpumask_clear_cpu needs non-const type,so here I am using data->affinity,
instead of changing code "const struct cpumask *affinity;"
\
 
 \ /
  Last update: 2012-09-26 09:21    [W:0.088 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site