Messages in this thread | | | Date | Wed, 27 Jun 2012 11:58:00 +0300 | From | Dan Carpenter <> | Subject | Re: [Ksummit-2012-discuss] [ATTEND] Your upstream maintainer just isn't that into you... |
| |
On Mon, Jun 25, 2012 at 06:44:56PM -0700, Dan Williams wrote: > Can we do a better job of bounding the maximum latency for acceptance > or rejection of a patch?
I sent quite a few patches all over the kernel as part of my Smatch work. If I don't get feedback on my patch then I assume it will be merged. I've gone through my sent-mail box and collected the patches which weren't merged. Hopefully, this is useful in discussing maintainer submitter feedback.
Some of these patches are probably wrong but it would have been nice to get some feedback on that.
The SCSI subsystem obviously stands out as pretty bad. It's the only subsystem where you can send a patch over and over and not get a response. It's not that I think all my patches should be merged without any review and free hugs for everyone... For all the other patches in this list, I feel that the patches was dropped by mistake but in SCSI it was silently ignored as a policy.
Causes of patches being lost: * Poor changelog on a cleanup patch. * I didn't CC the person who introduced the bug so I never got their acked-by. * The patch wasn't obvious and the maintainer was planning to review it later and forgot. * Confusion about who was supposed to pull a patch. * Poor communication between the maintainer and me and I didn't realize they wanted me to redo the patch. Don't phrase your statements as questions.
regards, dan carpenter
| |