lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts.
Hi,

This bug is still present in linux-next.

regards,
dan carpenter

On Wed, Jan 11, 2012 at 12:32:34PM +0300, Dan Carpenter wrote:
> Hello Krishna Gudipati,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 5b7db7af522d: "[SCSI] bfa: Implement LUN Masking feature
> using the SCSI Slave Callouts." from Dec 20, 2011, leads to the
> following Smatch complaint:
>
> drivers/scsi/bfa/bfad_im.c +962 bfad_im_slave_alloc()
> warn: variable dereferenced before check 'rport' (see line 959)
>
> drivers/scsi/bfa/bfad_im.c
> 957 struct fc_rport *rport = starget_to_rport(scsi_target(sdev));
> 958 struct bfad_itnim_data_s *itnim_data =
> 959 (struct bfad_itnim_data_s *) rport->dd_data;
> ^^^^^^^
> New dereference.
>
> 960 struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;
> 961
> 962 if (!rport || fc_remote_port_chkready(rport))
> ^^^^^
> Old check.
>
> 963 return -ENXIO;
> 964
>
> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2012-06-27 12:42    [W:0.241 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site