| Date | Tue, 20 Nov 2012 15:10:06 +0530 | Subject | Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() | From | Viresh Kumar <> |
| |
On 20 November 2012 15:02, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Tue, Nov 20, 2012 at 01:22:17AM -0800, Dmitry Torokhov wrote: >> We'll need to invoke clk_unprepare() via a pointer in our devm_* >> conversion so let's uninline the pair. > > NAK. This breaks non-common clock using implementations.
Hi Russell,
Dummy routines for non-common clock are still there. Sorry, couldn't get why this will break those platforms:
+static inline int clk_prepare(struct clk *clk) +{ + might_sleep(); + return 0; +} + +static inline void clk_unprepare(struct clk *clk) +{ + might_sleep(); +} +
-- viresh
|