lkml.org 
[lkml]   [2012]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
Date
Quoting Viresh Kumar (2012-11-21 19:34:18)
> On 22 November 2012 02:13, Mike Turquette <mturquette@ti.com> wrote:
> > HAVE_CLK logically wraps HAVE_CLK_PREPARE. There is no point in
> > selecting HAVE_CLK_PREPARE without HAVE_CLK.
> >
> > Looking through the code I see that this used to be the case. Commit
> > 93abe8e "clk: add non CONFIG_HAVE_CLK routines" moved the
> > clk_(un)prepare declarations outside of #ifdef CONFIG_HAVE_CLK. That
> > commit was authored by you. Can you elaborate on why that aspect of the
> > patch was needed?
>
> Haha... Caught red handed :(
>
> Before this commit, nothing was enclosed within CONFIG_HAVE_CLK and
> this patch only introduced it. I am not really sure, why i kept
> prepare/unprepare
> out of it though :(
>
> Maybe because some platform at that time is using it directly, without
> CONFIG_HAVE_CLK. Not sure.
>

No worries. Looks like everything gets sorted out in the end ;)

Regards,
Mike

> --
> viresh


\
 
 \ /
  Last update: 2012-11-23 03:01    [W:0.075 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site