Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v1.3 1/4] lib: hex2bin converts ascii hexadecimal string to binary | Date | Thu, 11 Nov 2010 19:48:47 +0000 | From | David Howells <> |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> +void hex2bin(unsigned char *mem, char *buf, int count)
I think this needs a little adjustment. I would recommend something like the following declaration:
void hex2bin(u8 *buf, const char *data, size_t count)
since the output data is binary (so use u8*), you're only reading the source data (so should use a const pointer) and you don't want to see a negative count (so use size_t).
Also, I'd suggest calling the source arg 'data' and the output arg 'buf' or maybe src/dst.
David
| ![\](/images/icornerr.gif) |