Messages in this thread | | | Subject | Re: [PATCH v1.3 2/4] key: add tpm_send command | Date | Thu, 11 Nov 2010 19:48:51 +0000 | From | David Howells <> |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> Reviewd-by: Mimi Zohar <zohar@watson.ibm.com>
You've missed an 'e'.
> +int tpm_send(u32 chip_num, char *cmd, int buflen) > +{ > ... > + rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen, > + "attempting tpm_cmd");
Make cmd 'void *' to obviate the cast. Preferably it should be const too.
> + module_put(chip->dev->driver->owner);
Where's the corresponding module_get()? I suspect this should be wrapped to match tpm_chip_find_get().
David
| |