Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v1.3 2/4] key: add tpm_send command | Date | Fri, 12 Nov 2010 14:11:12 +0000 |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > > + module_put(chip->dev->driver->owner); > > > > Where's the corresponding module_get()? I suspect this should be wrapped to > > match tpm_chip_find_get(). > > > > David > > The module_get() is in tpm_chip_find_get(), which is just a helper. > (It's used this way throughout tpm.c)
I'd make a function tpm_chip_find_put() just to wrap module_put() and then place it with tpm_chip_find_get() in the sources. That makes it easier to see what's going on.
David
| |