Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v1.3 2/4] key: add tpm_send command | From | Mimi Zohar <> | Date | Thu, 11 Nov 2010 17:25:56 -0500 |
| |
On Thu, 2010-11-11 at 19:48 +0000, David Howells wrote: > Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > > Reviewd-by: Mimi Zohar <zohar@watson.ibm.com> > > You've missed an 'e'.
thanks, will fix
> > +int tpm_send(u32 chip_num, char *cmd, int buflen) > > +{ > > ... > > + rc = transmit_cmd(chip, (struct tpm_cmd_t *)cmd, buflen, > > + "attempting tpm_cmd"); > > Make cmd 'void *' to obviate the cast. Preferably it should be const too.
will do
> > + module_put(chip->dev->driver->owner); > > Where's the corresponding module_get()? I suspect this should be wrapped to > match tpm_chip_find_get(). > > David
The module_get() is in tpm_chip_find_get(), which is just a helper. (It's used this way throughout tpm.c)
thanks,
Mimi
| ![\](/images/icornerr.gif) |