| Date | Sun, 15 Feb 2009 23:25:27 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE() |
| |
Bartlomiej Zolnierkiewicz wrote:
> Convert SELECT_DRIVE() to use ->tf_load instead of ->OUTB.
> There should be no functional changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Index: b/drivers/ide/ide-iops.c > =================================================================== > --- a/drivers/ide/ide-iops.c > +++ b/drivers/ide/ide-iops.c > @@ -88,11 +88,15 @@ void SELECT_DRIVE (ide_drive_t *drive) > { > ide_hwif_t *hwif = drive->hwif; > const struct ide_port_ops *port_ops = hwif->port_ops; > + ide_task_t task; > > if (port_ops && port_ops->selectproc) > port_ops->selectproc(drive); > > - hwif->OUTB(drive->select.all, hwif->io_ports.device_addr); > + memset(&task, 0, sizeof(task)); > + task.tf_flags = IDE_TFLAG_OUT_DEVICE; > + > + drive->hwif->tf_load(drive, &task);
This actually doesn't seem like a bright idea to me, considering that this gets called when starting every request. How will you look at me adding the transport method for writing this register? :-)
MBR, Sergei
|