Messages in this thread | | | Date | Thu, 21 Aug 2008 21:56:21 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 04/18] ide: remove ide_setup_dma() |
| |
Hi, I wrote:
>> Export sff_dma_ops and then remove ide_setup_dma().
>> There should be no functional changes caused by this patch.
>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>> Index: b/drivers/ide/arm/palm_bk3710.c >> =================================================================== >> --- a/drivers/ide/arm/palm_bk3710.c >> +++ b/drivers/ide/arm/palm_bk3710.c >> @@ -318,15 +318,14 @@ static u8 __devinit palm_bk3710_cable_de >> static int __devinit palm_bk3710_init_dma(ide_hwif_t *hwif, >> const struct ide_port_info *d) >> { >> - unsigned long base = >> - hwif->io_ports.data_addr - IDE_PALM_ATA_PRI_REG_OFFSET; >> - >> printk(KERN_INFO " %s: MMIO-DMA\n", hwif->name); >> >> if (ide_allocate_dma_engine(hwif)) >> return -1; >> >> - ide_setup_dma(hwif, base); >> + hwif->dma_base = hwif->io_ports.data_addr - >> IDE_PALM_ATA_PRI_REG_OFFSET; >> + >> + hwif->dma_ops = &sff_dma_ops; >> >> return 0; >> }
> Unfortunately, this patch broke this driver:
> drivers/ide/arm/palm_bk3710.c:327: error: ‘sff_dma_ops’ undeclared > (first use in this function). The declatation of sff_dma_ops should've > been surrounded by:
> #ifdef CONFIG_BLK_DEV_IDEDMA_SFF
> not by:
> #ifdef CONFIG_BLK_DEV_IDEDMA_PCI
> the same as its definition is in ide-dma.c...
OK, Kevin Hilman said he's going to post a patch for this issue...
MBR, Sergei
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |