lkml.org 
[lkml]   [2009]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE()
Hello, I wrote:

>>> There should be no functional changes caused by this patch.
>>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>> Index: b/drivers/ide/ide-iops.c
>>> ===================================================================
>>> --- a/drivers/ide/ide-iops.c
>>> +++ b/drivers/ide/ide-iops.c
>>> @@ -88,11 +88,15 @@ void SELECT_DRIVE (ide_drive_t *drive)
>>> {
>>> ide_hwif_t *hwif = drive->hwif;
>>> const struct ide_port_ops *port_ops = hwif->port_ops;
>>> + ide_task_t task;
>>>
>>> if (port_ops && port_ops->selectproc)
>>> port_ops->selectproc(drive);
>>>
>>> - hwif->OUTB(drive->select.all, hwif->io_ports.device_addr);
>>> + memset(&task, 0, sizeof(task));
>>> + task.tf_flags = IDE_TFLAG_OUT_DEVICE;
>>> +
>>> + drive->hwif->tf_load(drive, &task);
>>
>> This actually doesn't seem like a bright idea to me, considering
>> that this gets called when starting every request. How will you look
>> at me adding the transport method for writing this register? :-)
> Convert SELECT_DRIVE() to use ->tf_load instead of ->OUTB.
>
> OTOH, adding such a "backdoor" to the taskfile doesn't seem very
> consistent...

... which didn't prevent libata from having such backdoor though, in
the form of dev_select() method.

MBR, Sergei




\
 
 \ /
  Last update: 2009-02-18 12:23    [W:0.073 / U:4.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site