lkml.org 
[lkml]   [2008]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 12/18] ide: use ->tf_load in actual_try_to_identify()
Date
On Saturday 21 June 2008, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
> > Convert actual_try_to_identify() to use ->tf_load instead of ->OUTB.
> >
> > There should be no functional changes caused by this patch.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
> [...]
> > Index: b/drivers/ide/ide-probe.c
> > ===================================================================
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> > @@ -290,9 +290,15 @@ static int actual_try_to_identify (ide_d
> > /* set features register for atapi
> > * identify command to be sure of reply
> > */
> > - if ((cmd == WIN_PIDENTIFY))
> > - /* disable dma & overlap */
> > - hwif->OUTB(0, io_ports->feature_addr);
> > + if (cmd == WIN_PIDENTIFY) {
> > + ide_task_t task;
> > +
> > + memset(&task, 0, sizeof(task));
> > + /* disable DMA & overlap */
> > + task.tf_flags = IDE_TFLAG_OUT_FEATURE;
> > +
> > + drive->hwif->tf_load(drive, &task);
> > + }
> >
>
> Eww, this is bulky but should be a part of your plan to switch to
> tf_load() method...

Yes on both matters:

- It is a part of The Grand Plan. ;)

- I also don't like the small increase of complexity but these changes
make the core code completely independent of the hardware I/O registers
(allowing any taskfile transport method).

PS Thanks for reviewing these patches.

Bart


\
 
 \ /
  Last update: 2008-06-21 21:25    [W:0.044 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site