Messages in this thread | | | Date | Tue, 12 Aug 2008 10:25:08 -0400 (EDT) | From | Alan Stern <> | Subject | Possible false positive in checkpatch |
| |
The following appears to be a false positive in checkpatch:
ERROR: space prohibited after that '*' (ctx:BxW) #163: FILE: drivers/usb/core/usb.c:304: +#define usb_device_pm_ops (* (struct pm_ops *) 0) ^
Certainly this is a rather uncommon code construction, but similar ones might occur elsewhere. To my eyes,
(* (type *) ptr)
looks better than
(*(type *) ptr)
or
(*(type *)ptr)
or even
(*(type*)ptr)
but of course this is a matter of opinion. Is there any strong feeling about this in the kernel community?
Alan Stern
| |