lkml.org 
[lkml]   [2008]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Possible false positive in checkpatch
Alan Stern wrote:
> The following appears to be a false positive in checkpatch:
>
> ERROR: space prohibited after that '*' (ctx:BxW)
> #163: FILE: drivers/usb/core/usb.c:304:
> +#define usb_device_pm_ops (* (struct pm_ops *) 0)
> ^
>
> Certainly this is a rather uncommon code construction, but similar
> ones might occur elsewhere. To my eyes,
>
> (* (type *) ptr)
>
> looks better than
>
> (*(type *) ptr)
>
> or
>
> (*(type *)ptr)
>
> or even
>
> (*(type*)ptr)
>
> but of course this is a matter of opinion. Is there any strong feeling
> about this in the kernel community?
>

Personally, I rather strongly prefer (*(type *)ptr).

-hpa


\
 
 \ /
  Last update: 2008-08-16 00:01    [W:0.050 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site