lkml.org 
[lkml]   [2008]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Possible false positive in checkpatch
On Fri, 15 Aug 2008, H. Peter Anvin wrote:

> Alan Stern wrote:
> > The following appears to be a false positive in checkpatch:
> >
> > ERROR: space prohibited after that '*' (ctx:BxW)
> > #163: FILE: drivers/usb/core/usb.c:304:
> > +#define usb_device_pm_ops (* (struct pm_ops *) 0)
> > ^
> >
> > Certainly this is a rather uncommon code construction, but similar
> > ones might occur elsewhere. To my eyes,
> >
> > (* (type *) ptr)
> >
> > looks better than
> >
> > (*(type *) ptr)
> >
> > or
> >
> > (*(type *)ptr)
> >
> > or even
> >
> > (*(type*)ptr)
> >
> > but of course this is a matter of opinion. Is there any strong feeling
> > about this in the kernel community?
> >
>
> Personally, I rather strongly prefer (*(type *)ptr).

It's probably safe to say that this is one of those gray areas where
one need not adhere strictly to checkpatch's recommendations.

Alan Stern



\
 
 \ /
  Last update: 2008-08-16 17:29    [W:0.046 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site