lkml.org 
[lkml]   [2008]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: whomto.pl -- finding out whom to send patches to
On 5/30/08, Andrea Righi <righi.andrea@gmail.com> wrote:
> Vegard Nossum wrote:
>
> > Hi,
> >
> > I've written this perl script that takes a patch as input and prints the
> > authors/committers of the affected lines, using git-blame as the back end.

...

> > (Improvements are of course also welcome.)
> >
>
> Minor fix: do not git-blame /dev/null in patches that add new files.
>
> -Andrea
>
> diff -urpN linux/whomto.orig.pl linux/whomto.pl
> --- linux/whomto.orig.pl 2008-05-30 09:43:08.000000000 +0200
> +++ linux/whomto.pl 2008-05-30 09:49:26.000000000 +0200
> @@ -101,6 +101,7 @@ sub parse_patch {
>
> for (@p) {
> if (m/^--- .*?\/([^\s~]*)/) {
> + next if ($1 eq 'dev/null');
> $file = $files{$1} = {
> chunks => [],
> };
>

I missed that, thanks :-)

(Other diff programs may also use other paths for new files, so I'm
also adding an -f check.)


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036


\
 
 \ /
  Last update: 2008-05-31 12:07    [W:0.090 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site