Messages in this thread | | | Date | Sat, 24 May 2008 08:42:01 +0200 | From | Sam Ravnborg <> | Subject | Re: kernel coding style for if ... else which cross #ifdef |
| |
On Fri, May 23, 2008 at 10:42:58PM -0700, H. Peter Anvin wrote: > Sam Ravnborg wrote: > >>*However*, the best would really be if we changed Kconfig to emit > >>configuration constants what were 0/1 instead of undefined/defined. > >>That way we could do: > >> > >> if (CONFIG_SOMETHING && foo) { > >> /* ... something ... */ > >> } else if ((mode & S_IWUGO) == 0) { > >> /* ... */ > > > >We could do that - but then it would need another > >name not to clash with all the places where we rely > >on CONFIG_FOO='n' => CONFIG_FOO is not defined. > > > >We could teach kconfig to emit something like: > >#define KFOO 0 (for the 'n' value) > >And 1 or 2 for the y and m values. > > > > I don't think we want to use "1 or 2"... I suspect we want to use the > same booleans we currently have. I'm a bit dense (or I need more coffe - it's morning here). What "same booleans"?
> I would suggest CFG_* instead of CONFIG_* for the new set. Agreed.
Sam
| |