lkml.org 
[lkml]   [2008]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel coding style for if ... else which cross #ifdef
Sam Ravnborg wrote:
>> *However*, the best would really be if we changed Kconfig to emit
>> configuration constants what were 0/1 instead of undefined/defined.
>> That way we could do:
>>
>> if (CONFIG_SOMETHING && foo) {
>> /* ... something ... */
>> } else if ((mode & S_IWUGO) == 0) {
>> /* ... */
>
> We could do that - but then it would need another
> name not to clash with all the places where we rely
> on CONFIG_FOO='n' => CONFIG_FOO is not defined.
>
> We could teach kconfig to emit something like:
> #define KFOO 0 (for the 'n' value)
> And 1 or 2 for the y and m values.
>

I don't think we want to use "1 or 2"... I suspect we want to use the
same booleans we currently have.

I would suggest CFG_* instead of CONFIG_* for the new set.

-hpa



\
 
 \ /
  Last update: 2008-05-24 07:49    [W:2.333 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site