lkml.org 
[lkml]   [2008]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel coding style for if ... else which cross #ifdef
Sam Ravnborg wrote:
>> I don't think we want to use "1 or 2"... I suspect we want to use the
>> same booleans we currently have.
> I'm a bit dense (or I need more coffe - it's morning here).
> What "same booleans"?

Sorry, we already have CONFIG_FOO (meaning =y) and CONFIG_FOO_MODULE
(meaning =m). This seems to work well and will generally do the right
thing.

If we had CFG_FOO=2 for the case of FOO=n then the clean use of:

if (CFG_FOO && blah)...

... wouldn't work as nicely.

>> I would suggest CFG_* instead of CONFIG_* for the new set.
> Agreed.

-hpa



\
 
 \ /
  Last update: 2008-05-24 20:11    [W:0.148 / U:1.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site