lkml.org 
[lkml]   [2008]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectkernel coding style for if ... else which cross #ifdef
A question splitting "else" and "if" on distinct lines vs. using an
extra line and extra #else came up as I was reviewing a proposed cifs
patch. Which is the preferred style?

#ifdef CONFIG_SOMETHING
if (foo)
something ...
else
#endif
if ((mode & S_IWUGO) == 0)

or alternatively

#ifdef CONFIG_SOMETHING
if (foo)
something ...
else if ((mode & S_IWUGO) == 0)
#else
if ((mode & S_IWUGO) == 0)
#endif


--
Thanks,

Steve


\
 
 \ /
  Last update: 2008-05-23 21:15    [W:0.055 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site