| Date | Wed, 16 Apr 2008 18:02:13 -0700 | From | Chris Wright <> | Subject | SUNRPC: Fix a memory leak in rpc_create() |
| |
-stable review patch. If anyone has any objections, please let us know. ---------------------
From: Chuck Lever <chuck.lever@oracle.com>
upstream commit: ed13c27e546667fb0967ae30f5070cd7f6455f90
Commit 510deb0d was supposed to move the xprt_create_transport() call in rpc_create(), but neglected to remove the old call site. This resulted in a transport leak after every rpc_create() call.
This leak is present in 2.6.24 and 2.6.25.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Chris Wright <chrisw@sous-sol.org> ---
net/sunrpc/clnt.c | 4 ---- 1 file changed, 4 deletions(-)
--- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -249,10 +249,6 @@ struct rpc_clnt *rpc_create(struct rpc_c }; char servername[20]; - xprt = xprt_create_transport(&xprtargs); - if (IS_ERR(xprt)) - return (struct rpc_clnt *)xprt; - /* * If the caller chooses not to specify a hostname, whip * up a string representation of the passed-in address. --
|