Messages in this thread | | | From | Chuck Lever <> | Subject | Re: SUNRPC: Fix a memory leak in rpc_create() | Date | Fri, 18 Apr 2008 10:42:19 -0400 |
| |
On Apr 17, 2008, at 6:06 PM, Trond Myklebust wrote: > On Thu, 2008-04-17 at 23:25 +0200, Stefan Lippers-Hollmann wrote: >> Hi >> >> On Donnerstag, 17. April 2008, you wrote: >>> -stable review patch. If anyone has any objections, please let us >>> know. >>> --------------------- >>> >>> From: Chuck Lever <chuck.lever@oracle.com> >>> >>> upstream commit: ed13c27e546667fb0967ae30f5070cd7f6455f90 >>> >>> Commit 510deb0d was supposed to move the xprt_create_transport() >>> call in >>> rpc_create(), but neglected to remove the old call site. This >>> resulted in >>> a transport leak after every rpc_create() call. >>> >>> This leak is present in 2.6.24 and 2.6.25. >> >> This patch might introduce a regression: >> > > Gah. You're quite right. The commit that introduced the leak was > merged > well after 2.6.24 was released despite what the changelog entry says > above: > > $ git describe 510deb0d > v2.6.24-3933-g510deb0 > > I should have double-checked before posting this to stable@kernel.org. > I'm very sorry...
I guessed it was required for 2.6.24 based on the patch dates (and a fuzzy recollection of which release the "bad" commit went in). The date on the "bad" commit was before the release of 2.6.24, so I assumed the fix should be applied in 2.6.24 as well.
Mea culpa.
-- Chuck Lever chuck[dot]lever[at]oracle[dot]com
| |