lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subjectmd: remove the super sysfs attribute from devices in an md array
    -stable review patch.  If anyone has any objections, please let us know.
    ---------------------

    From: NeilBrown <neilb@suse.de>

    upstream commit: 0e82989d95cc46cc58622381eafa54f7428ee679

    Exposing the binary blob which is the md 'super-block' via sysfs doesn't
    really fit with the whole sysfs model, and ever since commit
    8118a859dc7abd873193986c77a8d9bdb877adc8 ("sysfs: fix off-by-one error
    in fill_read_buffer()") it doesn't actually work at all (as the size of
    the blob is often one page).

    (akpm: as in, fs/sysfs/file.c:fill_read_buffer() goes BUG)

    So just remove it altogether. It isn't really useful.

    Signed-off-by: Neil Brown <neilb@suse.de>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    drivers/md/md.c | 12 ------------
    1 file changed, 12 deletions(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -1847,17 +1847,6 @@ static struct rdev_sysfs_entry rdev_stat
    __ATTR(state, S_IRUGO|S_IWUSR, state_show, state_store);

    static ssize_t
    -super_show(mdk_rdev_t *rdev, char *page)
    -{
    - if (rdev->sb_loaded && rdev->sb_size) {
    - memcpy(page, page_address(rdev->sb_page), rdev->sb_size);
    - return rdev->sb_size;
    - } else
    - return 0;
    -}
    -static struct rdev_sysfs_entry rdev_super = __ATTR_RO(super);
    -
    -static ssize_t
    errors_show(mdk_rdev_t *rdev, char *page)
    {
    return sprintf(page, "%d\n", atomic_read(&rdev->corrected_errors));
    @@ -1959,7 +1948,6 @@ __ATTR(size, S_IRUGO|S_IWUSR, rdev_size_

    static struct attribute *rdev_default_attrs[] = {
    &rdev_state.attr,
    - &rdev_super.attr,
    &rdev_errors.attr,
    &rdev_slot.attr,
    &rdev_offset.attr,
    --


    \
     
     \ /
      Last update: 2008-04-17 03:09    [W:4.157 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site