| Date | Fri, 21 Nov 2008 17:57:30 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 07/10] x86: add checks for alloc/free_coherent code |
| |
please use this nice and clean structure init style:
> + entry->type = DMA_DEBUG_COHERENT; > + entry->dev = dev; > + entry->cpu_addr = virt; > + entry->size = size; > + entry->dev_addr = dma_addr; > + entry->direction = DMA_BIDIRECTIONAL;
here too:
> + struct dma_debug_entry ref = { > + .type = DMA_DEBUG_COHERENT, > + .dev = dev, > + .cpu_addr = virt, > + .dev_addr = addr, > + .size = size, > + .direction = DMA_BIDIRECTIONAL, > + };
Ingo
|