Messages in this thread | | | Date | Fri, 21 Nov 2008 17:42:54 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 02/10] x86: add data structures for DMA-API debugging |
| |
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> +#ifndef __ASM_X86_DMA_DEBUG > +#define __ASM_X86_DMA_DEBUG > + > +/* Allocation flags */ > +#define DMA_DEBUG_SINGLE 0 > +#define DMA_DEBUG_SG 1 > +#define DMA_DEBUG_COHERENT 2
please use enum for such internal flags, not define.
> + > +struct device; > +struct list_head; > + > +struct dma_debug_entry { > + struct list_head list; > + struct device *dev; > + int type; > + void *cpu_addr; > + u64 dev_addr; > + u64 size; > + int direction; > +};
please align new x86/include structures vertically like this:
> +struct dma_debug_entry { > + struct list_head list; > + struct device *dev; > + int type; > + void *cpu_addr; > + u64 dev_addr; > + u64 size; > + int direction; > +};
[ for the arts major students reading lkml ;-) ]
Ingo
| |