Messages in this thread | | | Date | Fri, 21 Nov 2008 17:49:23 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 02/10] x86: add data structures for DMA-API debugging |
| |
On Fri, Nov 21, 2008 at 05:42:54PM +0100, Ingo Molnar wrote: > > * Joerg Roedel <joerg.roedel@amd.com> wrote: > > > +#ifndef __ASM_X86_DMA_DEBUG > > +#define __ASM_X86_DMA_DEBUG > > + > > +/* Allocation flags */ > > +#define DMA_DEBUG_SINGLE 0 > > +#define DMA_DEBUG_SG 1 > > +#define DMA_DEBUG_COHERENT 2 > > please use enum for such internal flags, not define. > > > + > > +struct device; > > +struct list_head; > > + > > +struct dma_debug_entry { > > + struct list_head list; > > + struct device *dev; > > + int type; > > + void *cpu_addr; > > + u64 dev_addr; > > + u64 size; > > + int direction; > > +}; > > please align new x86/include structures vertically like this: > > > +struct dma_debug_entry { > > + struct list_head list; > > + struct device *dev; > > + int type; > > + void *cpu_addr; > > + u64 dev_addr; > > + u64 size; > > + int direction; > > +}; > > [ for the arts major students reading lkml ;-) ]
Ok, I will update the patch :)
Joerg
-- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
| |