Messages in this thread | | | Date | Fri, 21 Nov 2008 17:48:55 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 01/10] x86: add Kconfig entry for DMA-API debugging |
| |
On Fri, Nov 21, 2008 at 05:40:14PM +0100, Ingo Molnar wrote: > > * Joerg Roedel <joerg.roedel@amd.com> wrote: > > > +config DMA_API_DEBUG > > + default n > > 'default n' can be omitted in general from interactive Kconfig > entries.
Ok, then I remove it.
> > > + bool "Enable debugging of DMA-API usage" > > + depends on X86 > > perhaps add a proper dependency on iommu or swiotlb presence as well - > in case we decide to make it all disable-able again and dont have the > callbacks present?
No problem. But its hard to believe that we make the DMA-API disable-able some day ;) The best dependency in this case should be SWIOTLB I think.
Joerg
-- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
| |