Messages in this thread | | | Date | Wed, 27 Sep 2023 16:56:41 +0200 | Subject | Re: [PATCH v1 05/13] thermal: core: Store trip pointer in struct thermal_instance | From | Daniel Lezcano <> |
| |
On 21/09/2023 19:52, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Replace the integer trip number stored in struct thermal_instance with > a pointer to the relevant trip and adjust the code using the structure > in question accordingly. > > The main reason for making this change is to allow the trip point to > cooling device binding code more straightforward, as illustrated by > subsequent modifications of the ACPI thermal driver, but it also helps > to clarify the overall design and allows the governor code overhead to > be reduced (through subsequent modifications). > > The only case in which it adds complexity is trip_point_show() that > needs to walk the trips[] table to find the index of the given trip > point, but this is not a critical path and the interface that > trip_point_show() belongs to is problematic anyway (for instance, it > doesn't cover the case when the same cooling devices is associated > with multiple trip points). > > This is a preliminary change and the affected code will be refined by > a series of subsequent modifications of thermal governors, the core and > the ACPI thermal driver. > > The general functionality is not expected to be affected by this change. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > ---
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |