Messages in this thread | | | Date | Fri, 22 Sep 2023 19:52:17 -0600 | Subject | Re: [PATCH 05/14] net: enetc: Annotate struct enetc_int_vector with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/22/23 11:28, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct enetc_int_vector. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Claudiu Manoil <claudiu.manoil@nxp.com> > Cc: Vladimir Oltean <vladimir.oltean@nxp.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/net/ethernet/freescale/enetc/enetc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/ethernet/freescale/enetc/enetc.h > index 7439739cd81a..a9c2ff22431c 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc.h > +++ b/drivers/net/ethernet/freescale/enetc/enetc.h > @@ -297,7 +297,7 @@ struct enetc_int_vector { > char name[ENETC_INT_NAME_MAX]; > > struct enetc_bdr rx_ring; > - struct enetc_bdr tx_ring[]; > + struct enetc_bdr tx_ring[] __counted_by(count_tx_rings); > } ____cacheline_aligned_in_smp; > > struct enetc_cls_rule {
| |