lkml.org 
[lkml]   [2023]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 07/14] net: mana: Annotate struct mana_rxq with __counted_by
    From


    On 9/22/23 11:28, Kees Cook wrote:
    > Prepare for the coming implementation by GCC and Clang of the __counted_by
    > attribute. Flexible array members annotated with __counted_by can have
    > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
    > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
    > functions).
    >
    > As found with Coccinelle[1], add __counted_by for struct mana_rxq.
    >
    > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
    >
    > Cc: "K. Y. Srinivasan" <kys@microsoft.com>
    > Cc: Haiyang Zhang <haiyangz@microsoft.com>
    > Cc: Wei Liu <wei.liu@kernel.org>
    > Cc: Dexuan Cui <decui@microsoft.com>
    > Cc: Long Li <longli@microsoft.com>
    > Cc: Ajay Sharma <sharmaajay@microsoft.com>
    > Cc: "David S. Miller" <davem@davemloft.net>
    > Cc: Eric Dumazet <edumazet@google.com>
    > Cc: Jakub Kicinski <kuba@kernel.org>
    > Cc: Paolo Abeni <pabeni@redhat.com>
    > Cc: linux-hyperv@vger.kernel.org
    > Cc: linux-rdma@vger.kernel.org
    > Cc: netdev@vger.kernel.org
    > Signed-off-by: Kees Cook <keescook@chromium.org>


    Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

    Thanks
    --
    Gustavo

    > ---
    > include/net/mana/mana.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/include/net/mana/mana.h b/include/net/mana/mana.h
    > index 9f70b4332238..38441be68592 100644
    > --- a/include/net/mana/mana.h
    > +++ b/include/net/mana/mana.h
    > @@ -338,7 +338,7 @@ struct mana_rxq {
    > /* MUST BE THE LAST MEMBER:
    > * Each receive buffer has an associated mana_recv_buf_oob.
    > */
    > - struct mana_recv_buf_oob rx_oobs[];
    > + struct mana_recv_buf_oob rx_oobs[] __counted_by(num_rx_buf);
    > };
    >
    > struct mana_tx_qp {

    \
     
     \ /
      Last update: 2023-09-23 14:24    [W:4.256 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site