Messages in this thread | | | Date | Fri, 22 Sep 2023 19:52:41 -0600 | Subject | Re: [PATCH 06/14] net: hisilicon: Annotate struct rcb_common_cb with __counted_by | From | "Gustavo A. R. Silva" <> |
| |
On 9/22/23 11:28, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct rcb_common_cb. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Yisen Zhuang <yisen.zhuang@huawei.com> > Cc: Salil Mehta <salil.mehta@huawei.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > index a9f805925699..c1e9b6997853 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h > @@ -108,7 +108,7 @@ struct rcb_common_cb { > u32 ring_num; > u32 desc_num; /* desc num per queue*/ > > - struct ring_pair_cb ring_pair_cb[]; > + struct ring_pair_cb ring_pair_cb[] __counted_by(ring_num); > }; > > int hns_rcb_buf_size2type(u32 buf_size);
| |