Messages in this thread | | | From | Justin Lai <> | Subject | RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver | Date | Wed, 9 Aug 2023 06:49:29 +0000 |
| |
> On Thu, Aug 03, 2023 at 10:57:29AM +0200, Jiri Pirko wrote: > > Thu, Aug 03, 2023 at 10:25:13AM CEST, justinlai0215@realtek.com wrote: > > >This patch is to add the ethernet device driver for the PCIe > > >interface of Realtek Automotive Ethernet Switch, applicable to RTL9054, > RTL9068, RTL9072, RTL9075, RTL9068, RTL9071. > > > > > >Signed-off-by: justinlai0215 <justinlai0215@realtek.com> > > > > [...] > > > > > > >+ > > >+static long rtase_swc_ioctl(struct file *p_file, unsigned int cmd, > > >+unsigned long arg) > > > > There are *MANY* thing wrong in this patch spotted just during 5 > > minutes skimming over the code, but this definitelly tops all of them. > > I didn't see so obvious kernel bypass attempt for a long time. Ugh, > > you can't be serious :/ > > > > I suggest to you take couple of rounds of consulting the patch with > > some skilled upstream developer internaly before you make another > > submission in order not not to waste time of reviewers. > > I have to agree with Jiri here. This 'vendor crap' driver has no chance of being > merged as is. You need to reach out to some experienced mainline driver > developers to help you rewrite it to mainline quality. > > Andrew
Thank you for your reply, I will refer to your suggestions to modify my code.
| |