Messages in this thread | | | From | Justin Lai <> | Subject | RE: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver | Date | Wed, 9 Aug 2023 06:42:27 +0000 |
| |
> Thu, Aug 03, 2023 at 03:20:46PM CEST, justinlai0215@realtek.com wrote: > >Hi, Jiri Pirko > > > >Our device is multi-function, one of which is netdev and the other is > character device. For character devices, we have some custom functions that > must use copy_from_user or copy_to_user to pass data. > > 1. Don't top post > 2. That's nice you have it, but it is totally unacceptable. That's my > point. This is not about wrapping your out-of-tree driver and sending > it as is. You have to make sure you comply with the upstream code. > Which you don't, not even remotelly.
Thank you for your reply, I will refer to your suggestions to modify my code.
| |