Messages in this thread Patch in this message | | | From | Xia Fukun <> | Subject | [PATCH] serial: 8250_dw: Fix assignment error of data in dw8250_probe() | Date | Fri, 4 Aug 2023 20:16:07 +0800 |
| |
When the "ri-override" property is present in the device, data->msr_mask_on and UART_MSR_RI should be used for OR-assignment. Fix the errors in it.
Fixes: 1bd8edba10e6 ("serial: 8250_dw: adapt to unified device property interface") Signed-off-by: Xia Fukun <xiafukun@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 7db51781289e..921b5f07828f 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -587,7 +587,7 @@ static int dw8250_probe(struct platform_device *pdev) if (device_property_read_bool(dev, "ri-override")) { /* Always report Ring indicator as inactive */ - data->msr_mask_off |= UART_MSR_RI; + data->msr_mask_on |= UART_MSR_RI; data->msr_mask_off |= UART_MSR_TERI; } -- 2.17.1
| |