Messages in this thread | ![/](/images/icornerl.gif) | | From | Yunsheng Lin <> | Subject | [PATCH net-next v6 0/6] introduce page_pool_alloc() related API | Date | Mon, 14 Aug 2023 20:56:37 +0800 |
| |
In [1] & [2] & [3], there are usecases for veth and virtio_net to use frag support in page pool to reduce memory usage, and it may request different frag size depending on the head/tail room space for xdp_frame/shinfo and mtu/packet size. When the requested frag size is large enough that a single page can not be split into more than one frag, using frag support only have performance penalty because of the extra frag count handling for frag support.
So this patchset provides a page pool API for the driver to allocate memory with least memory utilization and performance penalty when it doesn't know the size of memory it need beforehand.
1. https://patchwork.kernel.org/project/netdevbpf/patch/d3ae6bd3537fbce379382ac6a42f67e22f27ece2.1683896626.git.lorenzo@kernel.org/ 2. https://patchwork.kernel.org/project/netdevbpf/patch/20230526054621.18371-3-liangchen.linux@gmail.com/ 3. https://github.com/alobakin/linux/tree/iavf-pp-frag
V6: add a PP_FLAG_PAGE_SPLIT_IN_DRIVER flag to fail the page_pool creation for 32-bit arch with 64-bit DMA when driver tries to do the page splitting itself, adjust the requested size to include head/tail room in veth, and rebased on the latest next-net.
v5 RFC: add a new page_pool_cache_alloc() API, and other minor change as discussed in v4. As there seems to be three comsumers that might be made use of the new API, so repost it as RFC and CC the relevant authors to see if the new API fits their need.
V4. Fix a typo and add a patch to update document about frag API, PAGE_POOL_DMA_USE_PP_FRAG_COUNT is not renamed yet as we may need a different thread to discuss that.
V3: Incorporate changes from the disscusion with Alexander, mostly the inline wraper, PAGE_POOL_DMA_USE_PP_FRAG_COUNT change split to separate patch and comment change. V2: Add patch to remove PP_FLAG_PAGE_FRAG flags and mention virtio_net usecase in the cover letter. V1: Drop RFC tag and page_pool_frag patch.
Yunsheng Lin (6): page_pool: frag API support for 32-bit arch with 64-bit DMA page_pool: unify frag_count handling in page_pool_is_last_frag() page_pool: remove PP_FLAG_PAGE_FRAG page_pool: introduce page_pool[_cache]_alloc() API page_pool: update document about frag API net: veth: use newly added page pool API for veth with xdp
Documentation/networking/page_pool.rst | 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 - .../net/ethernet/hisilicon/hns3/hns3_enet.c | 3 +- .../marvell/octeontx2/nic/otx2_common.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 3 +- drivers/net/veth.c | 24 +- drivers/net/wireless/mediatek/mt76/mac80211.c | 2 +- include/net/page_pool/helpers.h | 210 ++++++++++++++++-- include/net/page_pool/types.h | 38 ++-- net/core/page_pool.c | 30 +-- net/core/skbuff.c | 2 +- 11 files changed, 251 insertions(+), 69 deletions(-)
-- 2.33.0
| ![\](/images/icornerr.gif) |