Messages in this thread | | | Subject | Re: [PATCH net-next v6 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA | From | Yunsheng Lin <> | Date | Tue, 15 Aug 2023 20:31:01 +0800 |
| |
On 2023/8/15 19:24, Simon Horman wrote: > On Mon, Aug 14, 2023 at 08:56:38PM +0800, Yunsheng Lin wrote: > > ... > >> diff --git a/net/core/page_pool.c b/net/core/page_pool.c >> index 77cb75e63aca..d62c11aaea9a 100644 >> --- a/net/core/page_pool.c >> +++ b/net/core/page_pool.c > > ... > >> @@ -737,18 +736,16 @@ static void page_pool_free_frag(struct page_pool *pool) >> page_pool_return_page(pool, page); >> } >> >> -struct page *page_pool_alloc_frag(struct page_pool *pool, >> - unsigned int *offset, >> - unsigned int size, gfp_t gfp) >> +struct page *__page_pool_alloc_frag(struct page_pool *pool, >> + unsigned int *offset, >> + unsigned int size, gfp_t gfp) >> { >> unsigned int max_size = PAGE_SIZE << pool->p.order; >> struct page *page = pool->frag_page; >> >> - if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG) || >> - size > max_size)) >> + if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG)) > > Hi Yunsheng Lin, > > There is a ')' missing on the line above, which results in a build failure.
Yes, thanks for noticing. As the above checking is removed in patch 3, so it is not noticeable in testing when the whole patchset is applied.
>
| |