Messages in this thread | | | From | Frank Oltmanns <> | Subject | Re: [PATCH v3 0/8] clk: sunxi-ng: Consider alternative parent rates when determining NKM clock rate | Date | Mon, 03 Jul 2023 11:36:15 +0200 |
| |
On 2023-07-03 at 09:51:22 +0200, Maxime Ripard <maxime@cerno.tech> wrote: > [[PGP Signed Part:Undecided]] > Hi, > > On Sun, Jul 02, 2023 at 07:55:19PM +0200, Frank Oltmanns wrote: >> Changes in v3: >> - Use dedicated function for finding the best rate in cases where an >> nkm clock supports setting its parent's rate, streamlining it with >> the structure that is used in other sunxi-ng ccus such as ccu_mp >> (PATCH 1). >> - Therefore, remove the now obsolete comments that were introduced in >> v2 (PATCH 1). >> - Remove the dedicated function for calculating the optimal parent rate >> for nkm clocks that was introduced in v2. Instead use a simple >> calculation and require the parent clock to select the closest rate to >> achieve optimal results (PATCH 1). >> - Therefore, add support to set the closest rate for nm clocks (because >> pll-mipi's parent pll-video0 is an nm clock) and all clock types that >> are descendants of a64's pll-video0, i.e., nkm, mux, and div (PATCH 3 >> et. seq.). >> - Link to v2: https://lore.kernel.org/all/20230611090143.132257-1-frank@oltmanns.dev/ > > Thanks so much for that new version. I know it's been a long discussion, > but it definitely moves in the right direction and we're fairly close to > a final version now. >
I think it was a good discussion. So, thank you for that! I appreciate your feedback even though we don't always agree. :)
Thanks, Frank
> > Maxime > > [[End of PGP Signed Part]]
| |