Messages in this thread | | | From | Shenwei Wang <> | Subject | RE: [EXT] Re: [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link | Date | Fri, 28 Jul 2023 15:09:19 +0000 |
| |
> -----Original Message----- > From: Fabio Estevam <festevam@gmail.com> > Sent: Friday, July 28, 2023 6:01 AM > To: Shenwei Wang <shenwei.wang@nxp.com>; Andrew Lunn <andrew@lunn.ch> > Cc: Russell King <linux@armlinux.org.uk>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Maxime > Coquelin <mcoquelin.stm32@gmail.com>; Shawn Guo <shawnguo@kernel.org>; > Sascha Hauer <s.hauer@pengutronix.de>; Neil Armstrong > <neil.armstrong@linaro.org>; Kevin Hilman <khilman@baylibre.com>; Vinod > Koul <vkoul@kernel.org>; Chen-Yu Tsai <wens@csie.org>; Jernej Skrabec > <jernej.skrabec@gmail.com>; Samuel Holland <samuel@sholland.org>; > Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>; > Pengutronix Kernel Team <kernel@pengutronix.de>; dl-linux-imx <linux- > > > On Thu, Jul 27, 2023 at 12:25 PM Shenwei Wang <shenwei.wang@nxp.com> > wrote: > > > struct plat_stmmacenet_data *plat_dat = priv; @@ -317,8 > > +359,11 @@ static int imx_dwmac_probe(struct platform_device *pdev) > > plat_dat->exit = imx_dwmac_exit; > > plat_dat->clks_config = imx_dwmac_clks_config; > > plat_dat->fix_mac_speed = imx_dwmac_fix_speed; > > + if (of_machine_is_compatible("fsl,imx93")) > > + plat_dat->fix_mac_speed = imx_dwmac_fix_speed_mx93; > > So you are forcing this on all imx93 boards, even if they don't use a SJA1105. >
Yes, that's the purpose because it won't hurt even the other side is not SJA1105.
> Andrew Lunn gave the following feedback in v1: > > "The SJA1105 has the problem, so i would expect it to be involved in the solution. > Otherwise, how is this going to work for other MAC drivers? > > Maybe you need to expose a common clock framework clock for the TXC clock > line, which the SJA1105 can disable/enable? That then makes it clear what other > MAC drivers need to do."
I have been considering this plan for some time. The idea should be implemented across all i.mx8/9 platforms. I am going to start to work on it in the following month, and it will take some time to implement it.
Thanks, Shenwei
| |