Messages in this thread | | | From | Fabio Estevam <> | Date | Fri, 28 Jul 2023 08:00:32 -0300 | Subject | Re: [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link |
| |
On Thu, Jul 27, 2023 at 12:25 PM Shenwei Wang <shenwei.wang@nxp.com> wrote:
> struct plat_stmmacenet_data *plat_dat = priv; > @@ -317,8 +359,11 @@ static int imx_dwmac_probe(struct platform_device *pdev) > plat_dat->exit = imx_dwmac_exit; > plat_dat->clks_config = imx_dwmac_clks_config; > plat_dat->fix_mac_speed = imx_dwmac_fix_speed; > + if (of_machine_is_compatible("fsl,imx93")) > + plat_dat->fix_mac_speed = imx_dwmac_fix_speed_mx93;
So you are forcing this on all imx93 boards, even if they don't use a SJA1105.
Andrew Lunn gave the following feedback in v1:
"The SJA1105 has the problem, so i would expect it to be involved in the solution. Otherwise, how is this going to work for other MAC drivers?
Maybe you need to expose a common clock framework clock for the TXC clock line, which the SJA1105 can disable/enable? That then makes it clear what other MAC drivers need to do."
| |