lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH blktests v1 11/11] nvme: Add explicitly host to allow_host list
Date
On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> Only allow to connect to our setup target with the correct hostnqn.
>
> Thus we have to explicitly add the test hostnqn to the test subsysnqn
> allow_host list.

[...]

> --- a/tests/nvme/030
> +++ b/tests/nvme/030
> @@ -28,6 +28,7 @@ test() {
>
> _create_nvmet_subsystem "${subsys}1" "$(losetup -f)"
> _add_nvmet_subsys_to_port "${port}" "${subsys}1"
> + _create_nvmet_host "${subsys}1" "${def_hostnqn}"
>
> genctr=$(_discovery_genctr)
>
> @@ -36,13 +37,13 @@ test() {
>
> genctr=$(_check_genctr "${genctr}" "adding a subsystem to a port")
>
> - echo 0 > "${NVMET_CFS}/subsystems/${subsys}2/attr_allow_any_host"
> + _add_nvmet_allow_hosts "${subsys}2" "${def_hostnqn}"
>
> - genctr=$(_check_genctr "${genctr}" "clearing attr_allow_any_host")
> + genctr=$(_check_genctr "${genctr}" "adding host to allow_hosts")
>
> - echo 1 > "${NVMET_CFS}/subsystems/${subsys}2/attr_allow_any_host"
> + _remove_nvmet_allow_hosts "${subsys}2" "${def_hostnqn}"
>
> - genctr=$(_check_genctr "${genctr}" "setting attr_allow_any_host")
> + genctr=$(_check_genctr "${genctr}" "removing host from allow_hosts")
>
> _remove_nvmet_subsystem_from_port "${port}" "${subsys}2"
> _remove_nvmet_subsystem "${subsys}2"

The hunk above looks different from other changes. Is it changing test
content slightly to meet request by Max? If so, it would be good to note
in the commit message.
\
 
 \ /
  Last update: 2023-07-28 10:16    [W:0.137 / U:3.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site