Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid | Date | Fri, 28 Jul 2023 08:10:09 +0000 |
| |
On Jul 26, 2023 / 14:46, Daniel Wagner wrote: > Commit acc408477e85 ("nvme/{041,042,043,044,045,048}: Use default > hostnqn and hostid") switched the test over to use the default > hostnqn. It missed the change to remove the local variable and > use the def_hostnqn/def_hostid directly.
[...]
> diff --git a/tests/nvme/043 b/tests/nvme/043 > index 6392bd8b2492..5569a7a58ad5 100755 > --- a/tests/nvme/043 > +++ b/tests/nvme/043 > @@ -26,17 +26,13 @@ test() { > _setup_nvmet > > local port > - local hostid > - local hostnqn > local file_path="${TMPDIR}/img" > local hash > local dhgroup > local hostkey > local ctrldev > > - hostid="${def_hostid}" > - hostnqn="${def_hostnqn}" > - hostkey="$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)" > + hostkey="$(nvme gen-dhchap-key -n ${def_hostnqn} 2> /dev/null)"
As I commented on the previous patch, the left reference to subsys_name is replaced def_hostnqn. It means that the -n option value changes. I guess this change is fine for this test. Could you confirm it?
| |