Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH blktests v1 04/11] nvme: Use def_subsysnqn variable instead local variable | Date | Fri, 28 Jul 2023 08:04:41 +0000 |
| |
On Jul 26, 2023 / 14:46, Daniel Wagner wrote: > As all tests are using the same subsystem nqn anyway, use > the def_subsysnqn variable and drop the local subsys_name > variable.
[...]
> diff --git a/tests/nvme/043 b/tests/nvme/043 > index 4a37f91e50c3..6392bd8b2492 100755 > --- a/tests/nvme/043 > +++ b/tests/nvme/043 > @@ -26,7 +26,6 @@ test() { > _setup_nvmet > > local port > - local subsys_name="blktests-subsystem-1"
The variable subsys_name is removed here, but this patch still leaves a reference to it. This causes this test case fail. The reference is removed in the next patch. I think the left reference should be replaced with def_subsysnqn in this patch.
| |