Messages in this thread | | | Date | Thu, 27 Jul 2023 08:25:52 +0200 | Subject | Re: [PATCH v2 26/61] mmc: sdhci-of-arasan: Convert to platform remove callback returning void | From | Michal Simek <> |
| |
On 7/26/23 06:00, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > drivers/mmc/host/sdhci-of-arasan.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 294dd605fd2b..160bab0c437c 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -2016,7 +2016,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > return ret; > } > > -static int sdhci_arasan_remove(struct platform_device *pdev) > +static void sdhci_arasan_remove(struct platform_device *pdev) > { > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > @@ -2034,8 +2034,6 @@ static int sdhci_arasan_remove(struct platform_device *pdev) > sdhci_pltfm_unregister(pdev); > > clk_disable_unprepare(clk_ahb); > - > - return 0; > } > > static struct platform_driver sdhci_arasan_driver = { > @@ -2046,7 +2044,7 @@ static struct platform_driver sdhci_arasan_driver = { > .pm = &sdhci_arasan_dev_pm_ops, > }, > .probe = sdhci_arasan_probe, > - .remove = sdhci_arasan_remove, > + .remove_new = sdhci_arasan_remove, > }; > > module_platform_driver(sdhci_arasan_driver);
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks, Michal
| |