Messages in this thread | | | Date | Thu, 27 Jul 2023 08:40:46 +0300 | Subject | Re: [PATCH v2 12/61] mmc: sdhci-of-at91: Convert to platform remove callback returning void | From | claudiu beznea <> |
| |
On 26.07.2023 06:59, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> --- > drivers/mmc/host/sdhci-of-at91.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index cd0134580a90..af5bc0caf29b 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -443,7 +443,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > return ret; > } > > -static int sdhci_at91_remove(struct platform_device *pdev) > +static void sdhci_at91_remove(struct platform_device *pdev) > { > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > @@ -461,8 +461,6 @@ static int sdhci_at91_remove(struct platform_device *pdev) > clk_disable_unprepare(gck); > clk_disable_unprepare(hclock); > clk_disable_unprepare(mainck); > - > - return 0; > } > > static struct platform_driver sdhci_at91_driver = { > @@ -473,7 +471,7 @@ static struct platform_driver sdhci_at91_driver = { > .pm = &sdhci_at91_dev_pm_ops, > }, > .probe = sdhci_at91_probe, > - .remove = sdhci_at91_remove, > + .remove_new = sdhci_at91_remove, > }; > > module_platform_driver(sdhci_at91_driver);
| |