| Date | Thu, 27 Jul 2023 02:51:32 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH v2 21/61] mmc: sdhci-s3c: Convert to platform remove callback returning void |
| |
Hi Yangtao,
On Wed, Jul 26, 2023 at 12:00:01PM +0800, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
|