Messages in this thread | | | Date | Wed, 26 Jul 2023 18:19:05 +0200 | Subject | Re: [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022 | From | Krzysztof Kozlowski <> |
| |
On 26/07/2023 18:14, Krzysztof Kozlowski wrote: > >> + shunt-resistor-micro-ohms: >> + description: >> + Shunt resistor value in micro-Ohm >> + defaults to <0> when not set >> + monitoring of current and power not supported when <0> >> + >> + shunt-gain: > > 1. Missing vendor prefix (does not look like generic property) > 2. -microvolt > >> + description: >> + Shunt gain to scale maximal shunt voltage to >> + 40mV, 80mV, 160mV, 320mV >> + defaults to <8> (320mV) when not set > > And then enum is for 40, 80, 160 and 320.
Also use "default: X" to choose default, instead of free-form text.
Best regards, Krzysztof
| |