Messages in this thread | | | Date | Thu, 27 Jul 2023 09:07:09 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022 |
| |
On Thu, Jul 27, 2023 at 09:35:28AM +0200, Carsten Spieß wrote:
> On 7/26/23 18:14, Krzysztof Kozlowski wrote: > >> + shunt-gain: > > 1. Missing vendor prefix (does not look like generic property) > > 2. -microvolt > > And then enum is for 40, 80, 160 and 320. > replaced with > renesas,shunt-range-milli-volts: > description: | > maximal shunt voltage range of 40mV, 80mV, 160mV or 320mV > $ref: /schemas/types.yaml#/definitions/uint32-array > default: 320 > enum: [40, 80, 160, 320]
The point of using -microvolt is that it is a standard suffix: https://github.com/devicetree-org/dt-schema/blob/c1e73ebea9fc07f7d7848f304301f755f1278a67/dtschema/schemas/property-units.yaml#L101 [unhandled content-type:application/pgp-signature] | |